fgerlits commented on code in PR #1798:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1798#discussion_r1610206267
##########
extensions/aws/s3/MultipartUploadStateStorage.h:
##########
@@ -41,13 +41,13 @@ struct MultipartUploadState {
: upload_id(upload_id),
part_size(part_size),
full_size(full_size),
- upload_time(upload_time) {}
+ upload_time(upload_time.Millis()) {}
std::string upload_id;
size_t uploaded_parts{};
uint64_t uploaded_size{};
uint64_t part_size{};
uint64_t full_size{};
- Aws::Utils::DateTime upload_time;
+ int64_t upload_time;
Review Comment:
after a few iterations (changed the state storage in a non-backwards
compatible way -- bad, then changed the public field to an
`Aws::Utils::DateTime` which must not contain a sub-millisecond component, but
there is no way to enforce this -- didn't like that either), I ended up
renaming the field in fc274719edf4c92f00ec99559287b5163dc19541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
