pvillard31 commented on code in PR #8867:
URL: https://github.com/apache/nifi/pull/8867#discussion_r1610598980


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/firehose/PutKinesisFirehose.java:
##########
@@ -130,9 +130,9 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
             for (final FlowFile flowFile : flowFiles) {
                 final String firehoseStreamName = 
context.getProperty(KINESIS_FIREHOSE_DELIVERY_STREAM_NAME).evaluateAttributeExpressions(flowFile).getValue();
 
-                session.read(flowFile, in -> 
recordHash.get(firehoseStreamName).add(Record.builder().data(SdkBytes.fromInputStream(in)).build()));
-
                 recordHash.computeIfAbsent(firehoseStreamName, k -> new 
ArrayList<>());
+                session.read(flowFile, in -> 
recordHash.get(firehoseStreamName).add(Record.builder().data(SdkBytes.fromInputStream(in)).build()));
+                
                 final List<FlowFile> flowFilesForStream = 
hashFlowFiles.computeIfAbsent(firehoseStreamName, k -> new ArrayList<>());

Review Comment:
   ```suggestion
                   session.read(flowFile, in -> 
recordHash.get(firehoseStreamName).add(Record.builder().data(SdkBytes.fromInputStream(in)).build()));
   
                   final List<FlowFile> flowFilesForStream = 
hashFlowFiles.computeIfAbsent(firehoseStreamName, k -> new ArrayList<>());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to