bbende commented on code in PR #8860:
URL: https://github.com/apache/nifi/pull/8860#discussion_r1611517108
##########
nifi-manifest/nifi-runtime-manifest-core/src/main/java/org/apache/nifi/runtime/manifest/impl/StandardComponentManifestBuilder.java:
##########
@@ -33,6 +35,8 @@ public class StandardComponentManifestBuilder implements
ComponentManifestBuilde
private final List<ProcessorDefinition> processors = new ArrayList<>();
private final List<ControllerServiceDefinition> controllerServices = new
ArrayList<>();
private final List<ReportingTaskDefinition> reportingTasks = new
ArrayList<>();
+ private final List<ParameterProviderDefinition> parameterProviders = new
ArrayList<>();
+ private final List<FlowAnalysisRuleDefinition> flowAnalysisRules = new
ArrayList<>();
Review Comment:
Just a heads up that the same two lists need to be added to the actual
`ComponentManifest` class, and this builder needs to set them:
https://github.com/apache/nifi/blob/main/c2/c2-protocol/c2-protocol-component-api/src/main/java/org/apache/nifi/c2/protocol/component/api/ComponentManifest.java#L32
Currently the final manifest.json doesn't end up with the parameter
providers and flow analysis rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
