lordgamez opened a new pull request, #1802: URL: https://github.com/apache/nifi-minifi-cpp/pull/1802
In case a function is called from the minifi_native python module from a user defined python processor and an error occurs in one of the python stable API functions, then instead of throwing our own exception we should only return with an error value. The Python API functions already raise an exception if an error occurs in the python code, that can be handled there instead of throwing an exception in the C++ code. In NiFi python processors this will be handled in the onTrigger method and we will get a proper traceback and the flow file will be transferred to the failure relationship instead of an error and rollback. This will help us debug any python errors easier and also handle the errors by moving them to the failure relationship the same way as the NiFi python extension works. https://issues.apache.org/jira/browse/MINIFICPP-2387 --------------------------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
