[
https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850286#comment-17850286
]
Vansh Chaudhary commented on NIFI-13231:
----------------------------------------
Hi [~exceptionfactory] , I've added the authentication with Private key.
can you check and review before i raise the pr request?
https://github.com/apache/nifi/compare/main...maybevanshh:nifi:main
> Update GitHubFlowRegistryClient to generate App Installation Token
> ------------------------------------------------------------------
>
> Key: NIFI-13231
> URL: https://issues.apache.org/jira/browse/NIFI-13231
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 2.0.0-M3
> Reporter: Brian Ghigiarelli
> Assignee: Vansh Chaudhary
> Priority: Major
>
> The new GitHubFlowRegistryClient accepts two types of authentication:
> # Personal Access Token
> # App Installation Token
> The App Installation Token requires the user to input the token as a
> property, then uses that to communicate with GitHub. However, this token is
> short-lived and would require frequent updates (~hourly).
> Instead of directly providing the token, the GitHubFlowRegistryClient should
> accept as properties:
> # App ID
> # Private Key (PEM text format)
> and use these values to generate a short-lived token, following the guide at
> https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
