mcgilman commented on code in PR #8893:
URL: https://github.com/apache/nifi/pull/8893#discussion_r1619554202


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/package.json:
##########
@@ -56,7 +56,7 @@
         "@angular/compiler-cli": "^17.1.3",
         "@happy-dom/jest-environment": "^14.10.1",
         "@nx/angular": "18.1.3",
-        "@nx/jest": "^18.1.3",
+        "@nx/jest": "18.3.4",

Review Comment:
   With an update to package.json we should also include the updated 
package-lock.json.



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/project.json:
##########
@@ -70,15 +70,16 @@
             }
         },
         "test": {
-            "executor": "@angular-builders/jest:run",
+            "executor": "@nx/jest:jest",
+            "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
             "options": {
-                "configPath": "./jest.config.ts"
+                "jestConfig": "apps/nifi/jest.config.ts"
             }
         },
         "lint": {
             "executor": "@angular-eslint/builder:lint",
             "options": {
-                "lintFilePatterns": ["src/**/*.ts"]
+                "lintFilePatterns": ["apps/nifi/src/**/*.ts"]

Review Comment:
   This is the closest I could comment on this but I am unable to run 
`lint:fix`. I receive the following error:
   
   ```
   > [email protected] lint:fix
   > nx lint --eslint-config .eslintrc.json --fix
   
   
   > nx run nifi:lint --eslint-config .eslintrc.json --fix
   
   
   Linting "nifi"...
   
    NX   Failed to load plugin '@nx' declared in '--config#overrides[1]': 
Cannot find module '@nx/eslint-plugin'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to