exceptionfactory commented on PR #8896:
URL: https://github.com/apache/nifi/pull/8896#issuecomment-2139888828

   > @exceptionfactory Thanks for the help on that! Looking at the javadoc on 
the method `isCommandFailed`
   > 
   > ```
   > /**
   >      * On some environment, the test command immediately fail with an 
IOException
   >      * because of the native UnixProcess.init method implementation 
difference.
   >      *
   >      * @return true, if the command fails
   >      */
   > ```
   > 
   > it would seems to indicate that the JUnit 5 `@EnabledOnOs` annotation 
should be used to run those unit tests this method is used in to only run on a 
Unix environment.
   
   Yes, that is just one of several issues with the test class as it stands. 
There are System.out.println() statements that should be removed, System 
properties that should be removed, and other issues. It would be worth 
rewriting from scratch, with the goal of modernizing the implementation and 
providing better coverage of some scenarios. Not something for this Jira issue, 
but something to consider separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to