mcgilman commented on code in PR #8906:
URL: https://github.com/apache/nifi/pull/8906#discussion_r1622959963
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java:
##########
@@ -412,7 +412,7 @@ private LogoutRequest completeLogoutRequest(final
HttpServletResponse httpServle
}
private String getNiFiLogoutCompleteUri() {
- return getNiFiUri() + "logout-complete";
+ return getNiFiUri() + "#/logout-complete";
Review Comment:
Good point. However, we cannot use that path because we use hash based
routing. The hash is inserted and all routes begin after it. This allows the
front end to handle routing independent of the path the application is deployed
to. Switching to path based routing is a possibility but is a larger effort.
Path based routing typically requires knowing the base path at build time.
There may be options for setting it at run time but this would need to be
investigated more thoroughly.
I was actually just evaluating this in the context of OIDC and there was an
issue with hash being encoded. So we'll need to consider the options here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
