martinzink commented on code in PR #1763: URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1624232894
########## extensions/standard-processors/controllers/JsonRecordSetWriter.h: ########## @@ -0,0 +1,107 @@ +/** +* Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include "PropertyDefinitionBuilder.h" +#include "Record.h" +#include "controllers/RecordSetWriter.h" +#include "core/FlowFile.h" +#include "core/ProcessSession.h" +#include "utils/Enum.h" + +namespace org::apache::nifi::minifi::standard { +enum class OutputGroupingType { + ARRAY, + ONE_LINE_PER_OBJECT +}; +} // namespace org::apache::nifi::minifi::standard + +namespace magic_enum::customize { +using OutputGroupingType = org::apache::nifi::minifi::standard::OutputGroupingType; + +template <> +constexpr customize_t enum_name<OutputGroupingType>(OutputGroupingType value) noexcept { + switch (value) { + case OutputGroupingType::ARRAY: + return "Array"; + case OutputGroupingType::ONE_LINE_PER_OBJECT: + return "One Line Per Object"; + } + return invalid_tag; +} +} // namespace magic_enum::customize + +namespace org::apache::nifi::minifi::standard { + +class JsonRecordSetWriter final : public core::RecordSetWriter { + public: + explicit JsonRecordSetWriter(const std::string_view name, const utils::Identifier& uuid = {}) : RecordSetWriter(name, uuid) {} + + JsonRecordSetWriter(JsonRecordSetWriter&&) = delete; + JsonRecordSetWriter(const JsonRecordSetWriter&) = delete; + JsonRecordSetWriter& operator=(JsonRecordSetWriter&&) = delete; + JsonRecordSetWriter& operator=(const JsonRecordSetWriter&) = delete; + + ~JsonRecordSetWriter() override = default; + + EXTENSIONAPI static constexpr const char* Description = + "Writes the results of a RecordSet as either a JSON Array or one JSON object per line. " + "If using Array output, then even if the RecordSet consists of a single row, it will be written as an array with a single element. " + "If using One Line Per Object output, the JSON objects cannot be pretty-printed."; + + EXTENSIONAPI static constexpr auto OutputGrouping = core::PropertyDefinitionBuilder<magic_enum::enum_count<OutputGroupingType>()>::createProperty("Output Grouping") + .withDescription("Specifies how the writer should output the JSON records (as an array or one object per line, e.g.) " + "Note that if 'One Line Per Object' is selected, then Pretty Print JSON is ignored.") Review Comment: good point, originally I just copy pasted NiFi's description, but admitedly it can be improved https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/a96de10e7be3ded6e2ac3e835673fd759b948294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
