[ 
https://issues.apache.org/jira/browse/NIFI-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799310#comment-15799310
 ] 

ASF GitHub Bot commented on NIFI-3278:
--------------------------------------

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1389
  
    +1 LGTM, ran unit tests and tried with data files of various size. Thanks 
@olegz , merging to master.


> TextLineDemarcator fails when InputStream ends with '\r' and its length 
> equals buffer length
> --------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3278
>                 URL: https://issues.apache.org/jira/browse/NIFI-3278
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 1.2.0
>
>
> This is really an edge case, but there is a bug in _isEol()_ operation which 
> attempts to read the next byte after call to _fill()_ even though that may be 
> the end of the stream. And it only happens IF the current character is '\r' 
> and the length of the InputStream is the length of the buffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to