rfellows commented on code in PR #8926:
URL: https://github.com/apache/nifi/pull/8926#discussion_r1626497912
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/src/assets/styles/_app.scss:
##########
@@ -351,43 +351,55 @@
}
}
-@mixin generate-nifi-theme($nifi-theme) {
+@mixin generate-supplemental-theme($supplemental-theme) {
// Get the color config from the theme.
- $nifi-theme-color-config: mat.get-color-config($nifi-theme);
+ $supplemental-theme-color-config:
mat.get-color-config($supplemental-theme);
// Get the color palettes from the color-config.
- $nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
- $nifi-theme-success-palette: map.get($nifi-theme-color-config, 'accent');
- $nifi-theme-caution-palette: map.get($nifi-theme-color-config, 'warn');
+ $supplemental-theme-surface-palette:
map.get($supplemental-theme-color-config, 'primary');
+ $supplemental-theme-success-palette:
map.get($supplemental-theme-color-config, 'accent');
+ $supplemental-theme-caution-palette:
map.get($supplemental-theme-color-config, 'warn');
// default/lighter/darker colors from the nifi theme palettes
Review Comment:
Should we update the comment here?
```suggestion
// default/lighter/darker colors from the supplemental theme palettes
```
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/src/assets/styles/_app.scss:
##########
@@ -408,39 +420,43 @@
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
Review Comment:
Should we update the comment here?
```suggestion
// NOTE: supplemental surface palette lighter/darker is purposefully
omitted here. Any application of supplemental surface colors should be as a
background-color to a surface DOM element. The surface color should switch from
light to dark depending on the mode for the theme.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
