exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2149892339
> I refactored SplitPCAP to use InputStreamCallback, but the only way I could think to expose any error messages for insertion into the original flowfile in case of failure was by using a static SplitPCAP.ERROR_REASON_VALUE string; probably not the best approach. Can anyone recommend a better way of doing so? Thanks! Thanks for the refactoring @JackHintonSmartDCSIT, I will take a closer look at the implementation. Using the static member variable is not an option because it is not thread-safe. Declaring a method-local variable inside `onTrigger` is one potential alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
