szaszm commented on code in PR #1811:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1811#discussion_r1629676919
##########
extensions/rocksdb-repos/DatabaseContentRepository.cpp:
##########
@@ -80,6 +80,8 @@ bool DatabaseContentRepository::initialize(const
std::shared_ptr<minifi::Configu
logger_->log_error("NiFi Content DB Repository database open {} fail",
directory_);
is_valid_ = false;
}
+
+ use_synchronous_writes_ =
configuration->get(Configure::nifi_content_repository_rocksdb_use_synchronous_writes).value_or("true")
== "true";
Review Comment:
I'd fall back to true on invalid values.
```suggestion
use_synchronous_writes_ =
configuration->get(Configure::nifi_content_repository_rocksdb_use_synchronous_writes).value_or("true")
!= "false";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
