exceptionfactory commented on code in PR #8940:
URL: https://github.com/apache/nifi/pull/8940#discussion_r1631666372
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -214,7 +214,7 @@ public void fetch(final FlowFile flowFile, final String
transitUri, final String
bytesFetched += flowFile.getSize();
flowFilesFetched++;
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -181,7 +181,7 @@ public void receive(final FlowFile flowFile, final String
transitUri, final Stri
bytesReceived += flowFile.getSize();
flowFilesReceived++;
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -323,7 +323,7 @@ public void invokeRemoteProcess(FlowFile flowFile, String
transitUri, String det
.setTransitUri(transitUri).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -536,7 +536,7 @@ public void modifyAttributes(final FlowFile flowFile, final
String details) {
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ATTRIBUTES_MODIFIED).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -486,7 +486,7 @@ public void clone(final FlowFile parent, final FlowFile
child, final boolean ver
eventBuilder.addParentFlowFile(parent);
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/persistence/StandardFlowConfigurationDAO.java:
##########
@@ -191,7 +191,7 @@ private void saveFlow(final FlowController controller,
final FlowSerializer<?> s
try {
archiveManager.archive(file);
} catch (final Exception ex) {
- LOG.error("Unable to archive flow configuration as requested
due to " + ex);
+ LOG.error("Unable to archive flow configuration as requested
", ex);
if (LOG.isDebugEnabled()) {
LOG.error("", ex);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java:
##########
@@ -1585,7 +1585,7 @@ public void shutdown(final boolean kill) {
try {
provenanceRepository.close();
} catch (final IOException ioe) {
- LOG.warn("There was a problem shutting down the Provenance
Repository: " + ioe.toString());
+ LOG.warn("There was a problem shutting down the Provenance
Repository", ioe);
if (LOG.isDebugEnabled()) {
LOG.warn("", ioe);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -135,7 +135,7 @@ public void fetch(final FlowFile flowFile, final String
transitUri, final String
.build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -405,7 +405,7 @@ public void modifyContent(final FlowFile flowFile, final
String details, final l
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.CONTENT_MODIFIED).setEventDuration(processingMillis).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java:
##########
@@ -1305,7 +1305,7 @@ protected synchronized void rollback(final boolean
penalize, final boolean rollb
try {
context.getFlowFileEventRepository().updateRepository(flowFileEvent,
connectable.getIdentifier());
} catch (final Exception e) {
- LOG.error("Failed to update FlowFileEvent Repository due to " + e);
+ LOG.error("Failed to update FlowFileEvent Repository", e);
if (LOG.isDebugEnabled()) {
LOG.error("", e);
}
Review Comment:
The previous behavior only printed the stack trace when debug was enabled.
Making this change to just log the error with the stack trace is a cleaner way
to go from a code perspective, and current log handling should provide
sufficient control over stack traces. As a result, this type of conditional can
be removed.
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -375,7 +375,7 @@ public void clone(final FlowFile parent, final FlowFile
child) {
eventBuilder.addParentFlowFile(parent);
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:
##########
@@ -76,7 +76,7 @@ public String getUserIdentityFromToken(final String
base64EncodedToken) throws J
}
return jws.getPayload().getSubject();
} catch (JwtException e) {
- logger.debug("The Base64 encoded JWT: " + base64EncodedToken);
+ logger.debug("The Base64 encoded JWT: {}", base64EncodedToken);
Review Comment:
This is a good opportunity to remove this log:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -368,7 +368,7 @@ public ProvenanceEventRecord drop(final FlowFile flowFile,
final String reason)
events.add(record);
return record;
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -516,7 +516,7 @@ public void modifyContent(final FlowFile flowFile, final
String details, final l
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.CONTENT_MODIFIED).setEventDuration(processingMillis).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -350,7 +350,7 @@ public void associate(final FlowFile flowFile, final String
alternateIdentifierN
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ADDINFO).setAlternateIdentifierUri(alternateIdentifierUri).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -382,7 +382,7 @@ public void expire(final FlowFile flowFile, final String
details) {
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.EXPIRE).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -586,7 +586,7 @@ public void create(final FlowFile flowFile, final String
details) {
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.CREATE).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java:
##########
@@ -646,7 +646,7 @@ private FlowController(
}
if (remoteInputHttpPort == null) {
- LOG.info("Not enabling HTTP(S) Site-to-Site functionality because
the '" + NiFiProperties.SITE_TO_SITE_HTTP_ENABLED + "' property is not true");
+ LOG.info("Not enabling HTTP(S) Site-to-Site functionality because
the '{}' property is not true", NiFiProperties.SITE_TO_SITE_HTTP_ENABLED);
Review Comment:
This is a good opportunity to switch this to a `debug` log.
```suggestion
LOG.debug("Not enabling HTTP(S) Site-to-Site functionality
because the '{}' property is not true",
NiFiProperties.SITE_TO_SITE_HTTP_ENABLED);
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -425,7 +425,7 @@ public void fork(final FlowFile parent, final
Collection<FlowFile> children, fin
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java:
##########
@@ -3224,7 +3224,7 @@ public void run() {
LOG.debug(usae.getMessage());
}
} catch (final Throwable ex) {
- LOG.warn("Failed to send heartbeat due to: " + ex);
+ LOG.warn("Failed to send heartbeat", ex);
if (LOG.isDebugEnabled()) {
LOG.warn("", ex);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java:
##########
@@ -1073,7 +1073,7 @@ public void run() {
try {
updateRemoteProcessGroups();
} catch (final Throwable t) {
- LOG.warn("Unable to update Remote Process Groups due
to " + t);
+ LOG.warn("Unable to update Remote Process Groups", t);
if (LOG.isDebugEnabled()) {
LOG.warn("", t);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -462,7 +462,7 @@ public void join(final Collection<FlowFile> parents, final
FlowFile child, final
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -273,7 +273,7 @@ public void send(final FlowFile flowFile, final String
transitUri, final String
bytesSent += flowFile.getSize();
flowFilesSent++;
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
##########
@@ -566,7 +566,7 @@ public void route(final FlowFile flowFile, final
Relationship relationship, fina
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ROUTE).setRelationship(relationship).setDetails(details).setEventDuration(processingDuration).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java:
##########
@@ -199,7 +199,7 @@ public void saveActions(final NiFiWebRequestContext
requestContext, final Collec
// record the operations
auditService.addActions(actions);
} catch (final Throwable t) {
- logger.warn("Unable to record actions: " + t.getMessage());
+ logger.warn("Unable to record actions", t);
if (logger.isDebugEnabled()) {
logger.warn(StringUtils.EMPTY, t);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -106,7 +106,7 @@ public void receive(final FlowFile flowFile, final String
transitUri, final Stri
.build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java:
##########
@@ -1072,7 +1072,7 @@ public synchronized void run() {
}
}
} catch (final Throwable t) {
- logger.error("Unable to save flow controller configuration due
to: " + t, t);
+ logger.error("Unable to save flow controller configuration",
t);
if (logger.isDebugEnabled()) {
logger.error("", t);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -277,7 +277,7 @@ ProvenanceEventRecord drop(final FlowFile flowFile, final
String reason) {
events.add(record);
return record;
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -321,7 +321,7 @@ public void fork(final FlowFile parent, final
Collection<FlowFile> children, fin
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -233,7 +233,7 @@ public void invokeRemoteProcess(FlowFile flowFile, String
transitUri, String det
.setTransitUri(transitUri).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -182,7 +182,7 @@ public void send(final FlowFile flowFile, final String
transitUri, final String
events.add(record);
}
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -475,7 +475,7 @@ public void create(final FlowFile flowFile, final String
details) {
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.CREATE).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -425,7 +425,7 @@ public void modifyAttributes(final FlowFile flowFile, final
String details) {
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ATTRIBUTES_MODIFIED).setDetails(details).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -358,7 +358,7 @@ public void join(final Collection<FlowFile> parents, final
FlowFile child, final
events.add(eventBuilder.build());
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -260,7 +260,7 @@ public void associate(final FlowFile flowFile, final String
alternateIdentifierN
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ADDINFO).setAlternateIdentifierUri(alternateIdentifierUri).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##########
@@ -455,7 +455,7 @@ public void route(final FlowFile flowFile, final
Relationship relationship, fina
final ProvenanceEventRecord record = build(flowFile,
ProvenanceEventType.ROUTE).setRelationship(relationship).setDetails(details).setEventDuration(processingDuration).build();
events.add(record);
} catch (final Exception e) {
- logger.error("Failed to generate Provenance Event due to " + e);
+ logger.error("Failed to generate Provenance Event", e);
if (logger.isDebugEnabled()) {
logger.error("", e);
}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
