mattyb149 commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1636607648
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnDescription.java:
##########
@@ -84,9 +84,6 @@ public static ColumnDescription from(final ResultSet
resultSet) throws SQLExcept
return new ColumnDescription(columnName, dataType, required, colSize
== 0 ? null : colSize, isNullable);
}
- public static String normalizeColumnName(final String colName, final
boolean translateColumnNames) {
- return colName == null ? null : (translateColumnNames ?
colName.toUpperCase().replace("_", "") : colName);
Review Comment:
Nah it's not necessary, if there's a driver that returns null for a column
name then the driver is plain wrong :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]