martinzink commented on code in PR #1812:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1812#discussion_r1637698976
##########
extensions/standard-processors/tests/unit/GetFileTests.cpp:
##########
@@ -292,3 +292,26 @@ TEST_CASE("GetFile sets attributes correctly") {
CHECK(flow_file->getAttribute(minifi::core::SpecialFlowAttribute::FILENAME) ==
"beta.txt");
}
}
+
+TEST_CASE("GetFile can use expression language in Directory property") {
Review Comment:
Based on the latest windows test failure you need something like this, and
you would also need to define TZ_DATA_DIR in
extensions/standard-processors/tests/CMakeLists.txt for unit tests aswell
(currently its only defined for integration tests)
```suggestion
TEST_CASE("GetFile can use expression language in Directory property") {
#ifdef WIN32
expression::dateSetInstall(TZ_DATA_DIR);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
