exceptionfactory commented on code in PR #8963:
URL: https://github.com/apache/nifi/pull/8963#discussion_r1640387851
##########
minifi/minifi-commons/minifi-commons-api/src/main/java/org/apache/nifi/minifi/commons/api/MiNiFiProperties.java:
##########
@@ -81,9 +81,8 @@ public enum MiNiFiProperties {
C2_KEEP_ALIVE_DURATION("c2.rest.keepAliveDuration", "5 min", false, true,
TIME_PERIOD_VALIDATOR),
C2_REST_HTTP_HEADERS("c2.rest.http.headers", "Accept:application/json",
false, true, VALID),
C2_CONFIG_DIRECTORY("c2.config.directory", "./conf", false, true, VALID),
- C2_RUNTIME_MANIFEST_IDENTIFIER("c2.runtime.manifest.identifier", "",
false, true, VALID),
- C2_RUNTIME_TYPE("c2.runtime.type", "", false, true, VALID),
- C2_ASSET_DIRECTORY("c2.asset.directory", "./asset", false, true, VALID),
+ C2_RUNTIME_MANIFEST_IDENTIFIER("c2.runtime.manifest.identifier", "minifi",
false, true, VALID),
+ C2_RUNTIME_TYPE("c2.runtime.type", "minifi-java", false, true, VALID),
C2_ASSET_DIRECTORY("c2.asset.directory", "./asset", false, true, VALID),
Review Comment:
This change seems unrelated, I recommend reverting it and making it in
another pull request if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
