mcgilman commented on code in PR #9027:
URL: https://github.com/apache/nifi/pull/9027#discussion_r1663091509
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts:
##########
@@ -1452,11 +1463,19 @@ export class CanvasUtils {
return d.dimensions.width - bBox.width - 20;
})
.attr('class', function () {
- if (terminatedThreads > 0) {
- return `active-thread-count-icon warn-color-darker`;
- } else {
- return `active-thread-count-icon primary-color`;
+ if (
+ selection.type === ComponentType.Processor ||
+ selection.type === ComponentType.InputPort ||
+ selection.type === ComponentType.OutputPort
Review Comment:
We should be checking `d.type` and maybe convert to a switch statement.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts:
##########
@@ -1428,6 +1428,17 @@ export class CanvasUtils {
return activeThreads;
}
})
+ .attr('class', function () {
+ if (
+ selection.type === ComponentType.Processor ||
+ selection.type === ComponentType.InputPort ||
+ selection.type === ComponentType.OutputPort
Review Comment:
We should be checking `d.type` and maybe convert to a switch statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]