[ 
https://issues.apache.org/jira/browse/NIFI-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804957#comment-15804957
 ] 

ASF GitHub Bot commented on NIFI-3293:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1403

    NIFI-3293 - Expose counters to reporting tasks, and send counters dat…

    …a in Ambari reporting task
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi reporting-counters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1403
    
----
commit 948c3d130676c6c24123da60ee2f5e420bfc948c
Author: Pierre Villard <pierre.villard...@gmail.com>
Date:   2017-01-06T15:12:00Z

    NIFI-3293 - Expose counters to reporting tasks, and send counters data in 
Ambari reporting task

----


> Expose counter repository to reporting tasks
> --------------------------------------------
>
>                 Key: NIFI-3293
>                 URL: https://issues.apache.org/jira/browse/NIFI-3293
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Minor
>
> At the moment a {{ReportingTask}} cannot access {{CounterRepository}}. It 
> would be nice to add this feature allowing reporting tasks to send counters 
> data.
> A first implementation would be to add counters data in metrics sent by the 
> Ambari Reporting Task so that custom graphs can be easily added in tools such 
> as Grafana.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to