mcgilman commented on code in PR #9072:
URL: https://github.com/apache/nifi/pull/9072#discussion_r1676464436
##########
nifi-frontend/src/main/frontend/apps/nifi-jolt-transform-ui/src/app/app.module.ts:
##########
@@ -55,8 +51,14 @@ import { JoltTransformJsonUiEffects } from
'./pages/jolt-transform-json-ui/state
],
providers: [
{ provide: MAT_FORM_FIELD_DEFAULT_OPTIONS, useValue: { appearance:
'outline' } },
- provideHttpClient(withInterceptors([]))
- ],
- bootstrap: [AppComponent]
+ provideHttpClient(withInterceptors([])),
+ provideHttpClient(
Review Comment:
Do we need both `provideHttpClient` calls?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/app.module.ts:
##########
@@ -96,8 +92,14 @@ import { BannerTextEffects } from
'./state/banner-text/banner-text.effects';
],
providers: [
{ provide: MAT_FORM_FIELD_DEFAULT_OPTIONS, useValue: { appearance:
'outline' } },
- provideHttpClient(withInterceptors([authInterceptor,
loadingInterceptor, pollingInterceptor]))
- ],
- bootstrap: [AppComponent]
+ provideHttpClient(withInterceptors([authInterceptor,
loadingInterceptor, pollingInterceptor])),
+ provideHttpClient(
+ withInterceptorsFromDi(),
Review Comment:
I think we can be condensed. All of our interceptors have been converted to
function based so I don't think we need the `widthInterceptorsFromDi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
