[ 
https://issues.apache.org/jira/browse/NIFI-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867863#comment-17867863
 ] 

Daniel Stieglitz edited comment on NIFI-12709 at 7/22/24 8:21 PM:
------------------------------------------------------------------

[~joewitt]
I could not find in the Javadocs for [encrypted zip 
files|https://javadoc.io/doc/net.lingala.zip4j/zip4j/latest/net/lingala/zip4j/model/LocalFileHeader.html]
 and [unencrypted zip files 
|https://javadoc.io/static/org.apache.commons/commons-compress/1.26.2/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.html]
 any owner and creator information but I did find in both last modified time 
and in the unencrypted API even creation time. In addition I was able to find a 
unixMode in the unencrypted API. Also both API's have file size and 
uncompressed file size. Which one did you have in mind or should we include 
both? Lastly I am not sure why the the current implementation duplicates the 
creation and the last modified time for tar entries. I see in the 
[API|https://javadoc.io/doc/org.apache.commons/commons-compress/latest/org/apache/commons/compress/archivers/tar/TarArchiveEntry.html#getLastModifiedTime()]
 the ability to get both. 


was (Author: JIRAUSER294662):
[~joewitt]
I could not find in the Javadocs for [encrypted zip 
files|https://javadoc.io/doc/net.lingala.zip4j/zip4j/latest/net/lingala/zip4j/model/LocalFileHeader.html]
 and [unencrypted zip files 
|https://javadoc.io/static/org.apache.commons/commons-compress/1.26.2/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.html]
 any owner and creator information but I did find in both last modified time 
and in the unencrypted API even creation time. In addition I was able to find a 
unixMode in the unencrypted API. Also both API's have file size and 
uncompressed file size. Which one did you have in mind or should we include 
both? Lastly I am not sure why the the current implementation duplicates the 
creation and the last modified time for tar entries. I see in the API the 
ability to get both. 

> UnpackContent should save attributes from the zip entries as flowfile 
> attributes where possible
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-12709
>                 URL: https://issues.apache.org/jira/browse/NIFI-12709
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joe Witt
>            Assignee: Daniel Stieglitz
>            Priority: Major
>
> In an email from Jan 31st to users list titled 'ExecuteStreamCommand failing 
> to unzip incoming flowfiles'
> Issue is that UnpackContent doesn't capture much useful metadata.  The user 
> wants last modified date which is easily available, but also creator, 
> creation time, and owner which are less obviously avaialble at least not 
> consistently.  But there is a concept of extra fields we can extract metadata 
> from.  We have those same fields available from Tar files so it is natural 
> users would also want these.  Given their names aren't standard though I see 
> why Tar is the only one we currently say we support pulling those for.  If we 
> at least captured the metadata then flow builders can use it in their flows 
> as they wish whereas right now we dont expose that information.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to