EndzeitBegins commented on PR #9108: URL: https://github.com/apache/nifi/pull/9108#issuecomment-2248193849
Thank you for working on this @juldrixx. The addition of these properties seems coherent with other implementations. Instead of re-declaring both `SCHEMA_BRANCH_NAME` and `SCHEMA_VERSION` we may want to use those properties as declared in the [SchemaAccessUtils](https://github.com/apache/nifi/blob/main/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java). Other than that, the changes look good from my perspective. 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
