juldrixx commented on PR #9108: URL: https://github.com/apache/nifi/pull/9108#issuecomment-2254631030
> Besides the wording of the exception messages, the PR looks good to me now. Thank you for working on these improvements @juldrixx. 👍🏻 > > Just a minor hint towards contributing to the project. To ease the review of your contribution: > > > Please avoid using squash or --force when making these changes, as it will overwrite the remote branch and reduce the capability to track these changes. > > See the [contribution guidelines](https://cwiki.apache.org/confluence/display/nifi/contributor+guide#ContributorGuide-OpeningaPullRequest(PR)totheNiFiproject) for more details. I usually do it this way, but I wanted to respect the “Pull Request refers to a feature branch with one commit containing changes” rule, so I looked at the other PRs and saw cases of push forces, so I thought that was the right thing to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
