ChrisSamo632 commented on code in PR #9126: URL: https://github.com/apache/nifi/pull/9126#discussion_r1697641720
########## .github/workflows/docker-tests.yml: ########## @@ -16,8 +16,6 @@ name: docker-tests on: - schedule: - - cron: "0 2 * * *" Review Comment: For consideration (maybe not a blocker) - the docker tests will now only trigger if the docker files themselves or application assemblies are changed. While this will assure any such changes don't break things, we'll miss the possibility of assuring that changes within other modules haven't broken the assembly and running of the applications, e.g. if a change is made to `nifi.properties` but not catered for in the docker build and that subsequently prevents the application from running I can't say for certain that such a thing would be a pertinent, and I agree that reducing the number of GitHub Actions is a good thing, I wonder whether a reduction in frequency (e.g. weekly) rather than removal of the cron schedule would be more sensible in order to retain more of the existing QA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
