exceptionfactory commented on code in PR #9140:
URL: https://github.com/apache/nifi/pull/9140#discussion_r1701790067
##########
nifi-commons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardWebClientService.java:
##########
@@ -87,17 +98,16 @@ public void setConnectTimeout(final Duration
connectTimeout) {
*/
public void setReadTimeout(final Duration readTimeout) {
Objects.requireNonNull(readTimeout, "Read Timeout required");
- okHttpClient =
okHttpClient.newBuilder().readTimeout(readTimeout).build();
+ this.readTimeout = readTimeout;
}
/**
- * Set timeout for writing requests to socket connection
+ * Set timeout for writing requests to socket connection is not supported
with current HTTP Client implementation
Review Comment:
Thanks @joewitt. The changes already included handling of the `readTimeout`
property, passing it to the `HttpRequest.Builder`. However, for the sake of
completeness, I added handling for `writeTimeout`, but noted that `readTimeout`
is preferred. OkHttp had separate methods with different timeout behavior, but
the latest commit optionally uses `writeTimeout` for the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
