exceptionfactory commented on code in PR #9134:
URL: https://github.com/apache/nifi/pull/9134#discussion_r1704132993
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-content-viewer/src/main/java/org/apache/nifi/web/ContentViewerController.java:
##########
@@ -263,23 +260,11 @@ public String getRawContentType() {
*/
private ContentRequestContext getContentRequest(final HttpServletRequest
request) {
final String ref = request.getParameter("ref");
- final String clientId = request.getParameter("clientId");
-
- final UriBuilder refUriBuilder = UriBuilder.fromUri(ref);
-
- // base the data ref on the request parameter but ensure the scheme is
based off the incoming request...
- // this is necessary for scenario's where the NiFi instance is behind
a proxy running a different scheme
- refUriBuilder.scheme(request.getScheme());
+ final URI inputRefUri = UriBuilder.fromUri(ref).build();
+ final URI dataUri =
RequestUriBuilder.fromHttpServletRequest(request).path(inputRefUri.getPath()).build();
Review Comment:
Thanks for the feedback @mcgilman, I see the issue now with the URL changes
for clustered requests. I will correct that issue and review the
Content-Disposition handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
