fgerlits commented on code in PR #1850:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1850#discussion_r1709061925
##########
extensions/standard-processors/processors/InvokeHTTP.h:
##########
@@ -187,7 +177,7 @@ class InvokeHTTP : public core::Processor {
.withPropertyType(core::StandardPropertyTypes::DATA_TRANSFER_SPEED_TYPE)
.build();
- EXTENSIONAPI static constexpr auto Properties =
std::array<core::PropertyReference, 23>{
+ EXTENSIONAPI static constexpr auto Properties =
std::array<core::PropertyReference, 21>{
Review Comment:
You are right that this is ugly; it could be changed to
`std::to_array<core::PropertyReference>({Method, URL, ...})`. (Assuming all our
compilers support `to_array`, but I'd be surprised if they didn't.)
If this is changed, it should be changed everywhere and in a separate pull
request. If you create the PR, I'd be happy to approve it.
I have created a Jira for this:
https://issues.apache.org/jira/browse/MINIFICPP-2441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
