markap14 commented on code in PR #9159:
URL: https://github.com/apache/nifi/pull/9159#discussion_r1709509658
##########
nifi-extension-bundles/nifi-py4j-bundle/nifi-py4j-integration-tests/src/test/java/org.apache.nifi.py4j/PythonControllerInteractionIT.java:
##########
@@ -595,6 +595,21 @@ public void testCreateFlowFile() throws IOException {
multiLineContent.getBytes(StandardCharsets.UTF_8));
}
+ @Test
+ public void testCreateNothing() throws IOException {
+ /* Test the use-case where the source processor returns with None.
+ (The case must not result in Java NullPointerException.) */
Review Comment:
Probably not necessary to document that it shouldn't throw NPE's, that
should always be the case with all code :)
##########
nifi-extension-bundles/nifi-py4j-bundle/nifi-py4j-integration-tests/src/test/java/org.apache.nifi.py4j/PythonControllerInteractionIT.java:
##########
@@ -595,6 +595,21 @@ public void testCreateFlowFile() throws IOException {
multiLineContent.getBytes(StandardCharsets.UTF_8));
}
+ @Test
+ public void testCreateNothing() throws IOException {
+ /* Test the use-case where the source processor returns with None.
+ (The case must not result in Java NullPointerException.) */
+
+ final String processorName = "CreateNothing";
+ final String relationshipSuccess = "success";
Review Comment:
These variables are just static values that are used once. Would recommend
inlining the values rather than creating variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
