szaszm commented on code in PR #1854:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1854#discussion_r1716848332
##########
extensions/python/PythonScriptEngine.cpp:
##########
@@ -243,4 +243,24 @@ std::vector<core::Relationship>
PythonScriptEngine::getCustomPythonRelationships
return relationships;
}
+void PythonScriptEngine::setModuleAttributes(const std::string&
qualified_module_name) {
+ GlobalInterpreterLock gil;
Review Comment:
Reading this, I wonder when exactly we need to hold the GIL, and whether we
could make it more foolproof. (for fools like me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
