Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1407#discussion_r95629482
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
 ---
    @@ -115,20 +128,36 @@ public GenerateTableFetch() {
     
         @OnScheduled
         public void setup(final ProcessContext context) {
    +        // The processor is invalid if there is an incoming connection and 
max-value columns are defined
    +        if (context.getProperty(MAX_VALUE_COLUMN_NAMES).isSet() && 
context.hasIncomingConnection()) {
    +            throw new ProcessException("If an incoming connection is 
supplied, no max-value column names may be specified");
    --- End diff --
    
    The other concern was if we support Max Value columns using attributes, 
we'd have to keep state for those columns for each table, which could get 
unwieldy for state management depending on the number of columns and tables. 
Also if I add this logic, I'll need to change how state is stored (to change 
the key to a full-qualified column name), which could impact backwards 
compatibility (if state is maintained across an upgrade).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to