mcgilman commented on code in PR #9221: URL: https://github.com/apache/nifi/pull/9221#discussion_r1739226494
########## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/content-viewer/feature/content-viewer.component.html: ########## Review Comment: This implementation replaces a JSP/Servlet based approach where the markup is generated server side. In the previous implementation we had access to these details when building the response. The new client side implementation (which is invoked from a queue listing or a provenance event) does not have these details and these is no endpoint available to retrieve details about `content`. We do know the filename from the flowfile in the queue or from the provenance event. We could get the filename from those source resources and include in a query parameter just for the new content viewer to display. Having a query parameter whose sole purpose was to render a string on the page didn't seem like a great option. Instead of showing the mime type we've opted for those to be shown by the display name. So instead of seeing `application/xml` we see the `xml` option selected in the combo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
