[
https://issues.apache.org/jira/browse/NIFI-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878905#comment-17878905
]
Bryan Bende commented on NIFI-13694:
------------------------------------
[~markbean] the MissingComponentsCheck was comparing a Set<String> of
components ids that cluster says are missing vs the Set<String> that local node
says are missing. In the scenario you described there is no missing component
on the cluster or the local node... the local node has started with the new
version of the NAR and has a non-missing component at 2.0 so the Set from the
local node would be empty, and the cluster has the component at 1.0 and also
non-missing, so the cluster's Set would also be empty, so the check would not
have done anything. The scenario that was a problem was then the upgraded node
no longer has a NAR that was previously in use.
That being said, scenario you described is still important for rolling
upgrades, so I am curious, have you tested this and you are saying that you saw
all the components remain ghosted at the end? or are you saying you think that
is what would happen, but aren't sure?
Ideally the way I would hope it would work would be...
* Upgraded node attempts to join the cluster
* Gets flow from cluster where component is at 1.0
* Compares to local flow where component is at 2.0
* Determines this is a difference in the flow and calls synchronize
* Synchronize tries to change the component from 1.0 to 2.0, but there is no
2.0 and there is only one other choice of 1.0, so it keeps that
I don't know for sure if this how it works though, needs to be tested.
> Remove MissingComponentsCheck from flow synchronization
> -------------------------------------------------------
>
> Key: NIFI-13694
> URL: https://issues.apache.org/jira/browse/NIFI-13694
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Major
> Fix For: 2.0.0-M5
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Implement the change described here:
> https://cwiki.apache.org/confluence/display/NIFI/Remove+MissingComponentsCheck+from+Flow+Synchronization
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
