Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/38#discussion_r96006591
  
    --- Diff: CMakeLists.txt ---
    @@ -88,3 +88,10 @@ set(CPACK_ARCHIVE_COMPONENT_INSTALL ON)
     set(CPACK_COMPONENTS_ALL bin)
     
     include(CPack)
    +
    +# Create a custom build target called "docker" that will invoke 
DockerBuild.sh and create the NiFi-MiNiFi-CPP Docker image
    +add_custom_target(
    +    docker
    +    COMMAND ${CMAKE_SOURCE_DIR}/docker/DockerBuild.sh 1000 1000 0.2.0 
nifi-minifi-cpp-0.2.0-bin.tar.gz ${CMAKE_SOURCE_DIR}
    --- End diff --
    
    Would be good to to make use of the defined project version variables to 
avoid having to update this.  A bit more verbose, but would automatically be 
taken care of on release/version incrementing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to