[
https://issues.apache.org/jira/browse/NIFI-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822039#comment-15822039
]
ASF GitHub Bot commented on NIFI-3343:
--------------------------------------
GitHub user jdye64 opened a pull request:
https://github.com/apache/nifi/pull/1414
NIFI-3343
Annotate client dto fields with JsonFormat annotation to allow default
Jackson ObjectMapper implementation to be able to deserialize JSON.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdye64/nifi NIFI-3343
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1414
----
commit 45151dfdc85291071eae53f2445eeaf03a0052ee
Author: Jeremy Dyer <[email protected]>
Date: 2017-01-13T17:32:29Z
NIFI-3343
Annotate client dto fields with JsonFormat annotation to allow default
Jackson ObjectMapper implementation to be able to deserialize JSON.
----
> Annotate @XmlJavaTypeAdapter(DateTimeAdapter.class) fields in client dto with
> JsonFormat
> ----------------------------------------------------------------------------------------
>
> Key: NIFI-3343
> URL: https://issues.apache.org/jira/browse/NIFI-3343
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.1.1
> Reporter: Jeremy Dyer
> Assignee: Jeremy Dyer
> Fix For: 1.2.0
>
>
> Currently when implementing a client to consume NiFi client dto serialized
> objects Jackson is unable to deserialize
> @XmlJavaTypeAdapter(DateTimeAdapter.class) to a Java Date object since the
> format is unknown. Simply setting the default ObjectMapper default date using
> something like ...
> DateFormat dateFormat = new SimpleDateFormat("HH:mm:ss Z");
> this.mapper.setDateFormat(dateFormat);
> Will not work because there are portions that do have dates in this format.
> The only options seems to making the end users write their own custom date
> deserializers =( or annotating the dto object fields with @JsonFormat so that
> it is handled for them automatically.
> I plan to annotate the fields because that seems most efficient for everyone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
