fgerlits commented on code in PR #1861:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1861#discussion_r1759026696
##########
extensions/python/ExecutePythonProcessor.h:
##########
@@ -116,6 +116,14 @@ class ExecutePythonProcessor : public core::Processor {
return description_;
}
+ void setVersion(const std::string& version) {
+ version_ = version;
+ }
Review Comment:
Hm, I'm not sure. Is anyone going to set `ProcessorDetails.version = ""`? If
they do, would they expect to see the MiNiFi version in the C2 server GUI?
EDIT: I've changed my mind, because 1: we remove all key-value pairs with
empty values when we create the manifest, and 2: our C2 server implementation
crashes if it doesn't find a `version` key in a bundle in the manifest.
521a6c434f6242d804597058a846784a34341963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
