briansolo1985 commented on code in PR #9281:
URL: https://github.com/apache/nifi/pull/9281#discussion_r1770845916


##########
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-framework-core/src/main/java/org/apache/nifi/minifi/c2/C2NifiClientService.java:
##########
@@ -367,4 +368,27 @@ private List<ProcessorBulletin> getBulletins(int 
processorBulletinLimit) {
         }
         return new ArrayList<>();
     }
+
+    private List<ProcessorStatus> getProcessorStatus() {
+        return flowController.getEventAccess()
+                .getGroupStatus(ROOT_GROUP_ID)
+                .getProcessorStatus()
+                .stream()
+                .map(status -> {
+                    ProcessorStatus processorStatus = new ProcessorStatus();

Review Comment:
   Very minor, but maybe we could extract this to a separate method to make the 
streaming pipeline more concise



##########
c2/c2-protocol/c2-protocol-api/src/main/java/org/apache/nifi/c2/protocol/api/FlowInfo.java:
##########
@@ -31,6 +31,7 @@ public class FlowInfo implements Serializable {
     private Map<String, ComponentStatus> components;
     private Map<String, FlowQueueStatus> queues;
     private List<ProcessorBulletin> processorBulletins;
+    private List<ProcessorStatus> processors;

Review Comment:
   I think it would be more descriptive to call this member processorStatuses 
and also rename it's accessors



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to