exceptionfactory commented on code in PR #9288:
URL: https://github.com/apache/nifi/pull/9288#discussion_r1771952133
##########
nifi-docs/src/main/asciidoc/developer-guide.adoc:
##########
@@ -931,7 +931,7 @@ provides a "Usage" menu item in the context menu.
Additionally, the
UI exposes a "Help" link in the top-right corner, from which the same
Usage information can be found.
-The advanced documentation of a Processor is provided as an HTML file named
`additionalDetails.html`.
+The advanced documentation of a Processor is provided as an HTML file named
`additionalDetails.md`.
Review Comment:
```suggestion
The advanced documentation of a Processor is provided as a Markdown file
named `additionalDetails.md`.
```
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -3948,6 +3953,56 @@ public RuntimeManifest getRuntimeManifest() {
return controllerFacade.getRuntimeManifest();
}
+ @Override
+ public ProcessorDefinition getProcessorDefinition(String group, String
artifact, String version, String type) {
+ final ProcessorDefinition processorDefinition =
controllerFacade.getProcessorDefinition(group, artifact, version, type);
+ if (processorDefinition == null) {
+ throw new ResourceNotFoundException("Unable to find definition for
%s".formatted(type));
Review Comment:
The error message like it should include all of the coordinates instead of
just the `type` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
