dan-s1 commented on code in PR #9304:
URL: https://github.com/apache/nifi/pull/9304#discussion_r1772048926
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java:
##########
@@ -507,7 +515,19 @@ private ServerConnector createServerConnector(final Server
server,
final ClientAuthentication
clientAuthentication,
final HttpProtocolStrategy
httpProtocolStrategy
) {
- final StandardServerConnectorFactory serverConnectorFactory = new
StandardServerConnectorFactory(server, port);
+ NiFiProperties nifiProperties =
NiFiProperties.createBasicNiFiProperties(null);
+ int requestMaxHeaderSize =
DataUnit.parseDataSize(nifiProperties.getWebMaxHeaderSize(),
DataUnit.B).intValue();
Review Comment:
```suggestion
final NiFiProperties nifiProperties =
NiFiProperties.createBasicNiFiProperties(null);
final int requestMaxHeaderSize =
DataUnit.parseDataSize(nifiProperties.getWebMaxHeaderSize(),
DataUnit.B).intValue();
```
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java:
##########
@@ -380,7 +388,19 @@ synchronized void initializeServer(final ProcessContext
context) throws Exceptio
final String clientAuthValue =
context.getProperty(CLIENT_AUTH).getValue();
final Server server = createServer(context);
- final StandardServerConnectorFactory serverConnectorFactory = new
StandardServerConnectorFactory(server, port);
+ NiFiProperties nifiProperties =
NiFiProperties.createBasicNiFiProperties(null);
+ int requestMaxHeaderSize =
DataUnit.parseDataSize(nifiProperties.getWebMaxHeaderSize(),
DataUnit.B).intValue();
Review Comment:
Following the pattern of the rest of the variables these also should be
declared `final`
```suggestion
final NiFiProperties nifiProperties =
NiFiProperties.createBasicNiFiProperties(null);
final int requestMaxHeaderSize =
DataUnit.parseDataSize(nifiProperties.getWebMaxHeaderSize(),
DataUnit.B).intValue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
