turcsanyip commented on code in PR #9308:
URL: https://github.com/apache/nifi/pull/9308#discussion_r1774009451
##########
nifi-extension-bundles/nifi-airtable-bundle/nifi-airtable-processors/src/main/java/org/apache/nifi/processors/airtable/QueryAirtableTable.java:
##########
@@ -108,10 +108,11 @@ public class QueryAirtableTable extends AbstractProcessor
{
.required(true)
.build();
- static final PropertyDescriptor API_KEY = new PropertyDescriptor.Builder()
+ // API Keys are deprecated, Airtable now provides Personal Access Tokens
instead.
+ static final PropertyDescriptor PAT = new PropertyDescriptor.Builder()
.name("api-key")
- .displayName("API Key")
- .description("The REST API key to use in queries. Should be
generated on Airtable's account page.")
+ .displayName("Personal Access Token")
+ .description("The Personal Access Token (PAT) to use in queries.
Should be generated on Airtable's account page.")
Review Comment:
In NiFi 2.0 we can get rid of the old `api-key` property name too. You can
use `.name("pat")` and implement `migrateProperties()` method like this:
```
@Override
public void migrateProperties(final PropertyConfiguration config) {
config.renameProperty("api-key", PAT.getName());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
