[
https://issues.apache.org/jira/browse/NIFI-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822890#comment-15822890
]
ASF GitHub Bot commented on NIFI-3314:
--------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/1419
NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs
NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs such
that it does not need supporting build script. Making use of openjdk base
image as the java image has been deprecated.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [-] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi nifi-3314
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1419.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1419
----
commit 1bdadfbf39545f30afc639ec86c2511685459597
Author: Aldrin Piri <[email protected]>
Date: 2017-01-13T21:56:49Z
NIFI-3314 Adjusting Dockerfile for Docker Hub to use defaults for ARGs
such that it does not need supporting build script. Making use of
openjdk base image as the java image has been deprecated.
----
> Dockerfile makes use of ARGs which will not work in Docker Hub environment
> --------------------------------------------------------------------------
>
> Key: NIFI-3314
> URL: https://issues.apache.org/jira/browse/NIFI-3314
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Fix For: 1.2.0
>
>
> Dockerfile makes use of ARGs which are populated by
> nifi-docker/dockerhub/DockerBuild.sh but we do not have the capability to
> make use of this in the Docker Hub environment. Will need to either specify
> a default for the release or use Maven to provide these to the needed config
> files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
