exceptionfactory opened a new pull request, #9367: URL: https://github.com/apache/nifi/pull/9367
# Summary [NIFI-13579](https://issues.apache.org/jira/browse/NIFI-13579) Improves timestamp formatting and parsing for Record Readers and Record Writers as it relates to zone offset handling. Following significant changes to move from `java.util.Date` to `java.time` classes for earlier 2.0.0 milestone releases, zone offset handling no longer worked in ways similar to earlier versions. When reading a timestamp string with a zone offset, `LocalDateTime.parse()` would ignore the zone offset and only consider the local date and time components. When writing a timestamp as a string, the converter would throw an exception due to the `LocalDateTime` object not having a value for offset seconds. The current set of changes adjusts Field Converter behavior to address these issues. When converting from a string to a timestamp, the parsing makes use of the [DateTimeFormatter.parseBest()](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/time/format/DateTimeFormatter.html#parseBest(java.lang.CharSequence,java.time.temporal.TemporalQuery...)) method to first try parsing with `ZonedDateTime` to handle zone offsets, and then parsing with `LocalDateTime`. When converting from a Timestamp or `LocalDateTime` to a string, the conversion creates a `ZonedDateTime` from a `LocalDateTime` using the system default zone offset, avoiding unexpected zone offset conversion. Changes include new unit tests for these scenarios, as well as a new test for the `ValidateRecord` Processor with CSV Reader and Writer, exercising both sides of the conversion. These test methods get the current zone offset value from the JVM to ensure that tests work as expected regardless of the system timezone. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
