martinzink commented on code in PR #1876: URL: https://github.com/apache/nifi-minifi-cpp/pull/1876#discussion_r1794875294
########## .clang-format: ########## @@ -0,0 +1,67 @@ +BasedOnStyle: Google +AccessModifierOffset: -1 +AlignAfterOpenBracket: DontAlign +AlignConsecutiveAssignments: None +AlignOperands: DontAlign +AllowAllArgumentsOnNextLine: false +AllowAllConstructorInitializersOnNextLine: false +AllowAllParametersOfDeclarationOnNextLine: true +AllowShortBlocksOnASingleLine: Always +AllowShortCaseLabelsOnASingleLine: true +AllowShortFunctionsOnASingleLine: Inline +AllowShortIfStatementsOnASingleLine: Always +AllowShortLambdasOnASingleLine: All +AllowShortLoopsOnASingleLine: true +AlwaysBreakAfterReturnType: None +BreakTemplateDeclarations: Yes +BreakBeforeBraces: Custom +BraceWrapping: + AfterCaseLabel: false + AfterClass: false + AfterControlStatement: Never + AfterEnum: false + AfterFunction: false + AfterNamespace: false + AfterUnion: false + BeforeCatch: false + BeforeElse: false + IndentBraces: false Review Comment: Yeah, the bundled clang-format with clion is too old to support this it turned out (not sure where to force it to use the system one) ``` .clang-format:19:1: error: unknown key 'BreakTemplateDeclarations' BreakTemplateDeclarations: Yes ^~~~~~~~~~~~~~~~~~~~~~~~~ Error reading .clang-format: Invalid argument ``` I've readded the equivalent older (marked as deprecated) option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
