dan-s1 commented on code in PR #9379: URL: https://github.com/apache/nifi/pull/9379#discussion_r1799618989
########## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/CellFieldTypeReader.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.excel; + +import org.apache.nifi.schema.inference.FieldTypeInference; +import org.apache.nifi.serialization.record.DataType; +import org.apache.poi.ss.usermodel.Cell; + +import java.util.Map; + +/** + * Shared abstraction for determining Record Field Data Type from Spreadsheet Cell Types + */ +interface CellFieldTypeReader { + /** + * Infer Cell Field Type and update Map of Field Type information + * + * @param cell Spreadsheet Cell required + * @param fieldName Cell field name for tracking in Field Types + * @param fieldTypes Map of Field Name to Field Type Inference information Review Comment: Probably should add in the javadocs here that these other two arguments are also required as the first one and as you have required checks for 3 in the `StandardCellFieldTypeReader` implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
