dan-s1 commented on code in PR #9379: URL: https://github.com/apache/nifi/pull/9379#discussion_r1800013904
########## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/StandardCellFieldTypeReader.java: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.excel; + +import org.apache.nifi.schema.inference.FieldTypeInference; +import org.apache.nifi.schema.inference.TimeValueInference; +import org.apache.nifi.serialization.record.DataType; +import org.apache.nifi.serialization.record.RecordFieldType; +import org.apache.poi.ss.usermodel.Cell; +import org.apache.poi.ss.usermodel.CellType; +import org.apache.poi.ss.usermodel.DateUtil; + +import java.util.Map; +import java.util.Objects; +import java.util.Optional; + +/** + * Standard implementation of Cell Field Type Reader uses Cell Type and Cell Value information with inference based on Timestamp formats + */ +class StandardCellFieldTypeReader implements CellFieldTypeReader { + private final TimeValueInference timeValueInference; + + StandardCellFieldTypeReader(final TimeValueInference timeValueInference) { + this.timeValueInference = Objects.requireNonNull(timeValueInference, "Time Value Inference required"); + } + + /** + * Infer Cell Field Type and append possible Data Types to mapped Field Type Inference information + * + * @param cell Spreadsheet Cell required + * @param fieldName Cell field name for tracking in Field Types + * @param fieldTypes Map of Field Name to Field Type Inference information + */ + @Override + public void inferCellFieldType(final Cell cell, final String fieldName, final Map<String, FieldTypeInference> fieldTypes) { + Objects.requireNonNull(cell, "Cell required"); Review Comment: I do not think there should be this check as there can be cells which have no data in it and `Cell `will be null. I uncovered this running the `TestExcelReader` which I had created for my PR. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
