exceptionfactory commented on code in PR #9379:
URL: https://github.com/apache/nifi/pull/9379#discussion_r1801391101
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/test/java/org/apache/nifi/excel/TestExcelSchemaInference.java:
##########
@@ -50,69 +45,54 @@ public class TestExcelSchemaInference {
private static final String EXPECTED_SECOND_FIELD_NAME =
ExcelUtils.FIELD_NAME_PREFIX + "1";
private static final String EXPECTED_THIRD_FIELD_NAME =
ExcelUtils.FIELD_NAME_PREFIX + "2";
private static final String EXPECTED_FOURTH_FIELD_NAME =
ExcelUtils.FIELD_NAME_PREFIX + "3";
+
+ private static final String SIMPLE_FORMATTING_PATH =
"/excel/simpleDataFormatting.xlsx";
+
private final TimeValueInference timestampInference = new
TimeValueInference("MM/dd/yyyy", "HH:mm:ss.SSS", "yyyy/MM/dd/ HH:mm");
Review Comment:
Thanks, I changed the existing `TimeValueInference` to a mock, but added a
new test method with a `TimeValueInference` that handles a `STRING` field as a
timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
