exceptionfactory commented on PR #9379: URL: https://github.com/apache/nifi/pull/9379#issuecomment-2414736837
> @exceptionfactory With that change should we should also then improve what is returned by ExcelRecordReader on line 146? Currently we return a `java.util.Date` with `cell.getDateCellValue()` but I think we should employ similar logic to determine if its a DATE/TIME then call `cell.getLocalDateTimeCellValue()` to return a `java.time.LocalDateTime`. The `java.util.Date` and `java.time.LocalDateTime` values are functionally equivalent in terms of representing years, months, days, hours, minutes, and seconds. The potential difference could come in time zones, which `java.util.Date` has, but `LocalDateTime` does not. With the internal NiFi Record handling of timestamps as `java.sql.Timestamp`, I think this can stay as it is for now unless there is some other compelling reason to adjust the return value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
