exceptionfactory commented on code in PR #9371:
URL: https://github.com/apache/nifi/pull/9371#discussion_r1803908605
##########
nifi-extension-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js:
##########
@@ -1484,14 +1487,33 @@ var ua = {
conditions.push(condition.expression);
});
return conditions;
- } else {
- var actions = [];
- $.each(rule.actions, function (_, action) {
- actions.push(action.attribute);
- actions.push(action.value);
- });
- return actions;
- }
+ } else if (filterType.value === 'action') {
+ var actions = [];
Review Comment:
The indentation appears to be off in this new block, in comparison with the
other blocks.
##########
nifi-extension-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js:
##########
@@ -201,6 +201,9 @@ var ua = {
}, {
text: 'by action',
value: 'action'
+ }, {
+ text: 'filter everything',
Review Comment:
Following the existing pattern, it seems like it would be better to call
this `by any field` or `by any property`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
