scottyaslan commented on code in PR #9406:
URL: https://github.com/apache/nifi/pull/9406#discussion_r1805100193
##########
nifi-frontend/src/main/frontend/libs/shared/src/assets/themes/material.scss:
##########
@@ -367,6 +367,7 @@ $m3-light-theme-config: (
darker: 4,
default: 35,
lighter: 99,
+ disabled: 80,
Review Comment:
I don't really have a good answer for this. These icons should be disabled
and I think the color you are suggesting are a bit too dark and do not look
disabled but your point is well taken that the lighter grey color doesn't look
to pass contrast ratio. I just don't know what we could do here. What color
should a disabled icon be on a primary or secondary surface? I think we just
roll with this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
