exceptionfactory commented on code in PR #9429:
URL: https://github.com/apache/nifi/pull/9429#discussion_r1811116947
##########
mvnw:
##########
@@ -105,6 +106,21 @@ trim() {
printf "%s" "${1}" | tr -d '[:space:]'
}
+# find the Python executable
+if [ -z "${PYTHON_CMD-}" ]; then
+ for PYTHON_PATH in /usr/bin/python3 /usr/local/bin/python3 /usr/bin/python
/usr/local/bin/python; do
+ if [ -x "${PYTHON_PATH}" ]; then
+ export PYTHON_CMD="${PYTHON_PATH}"
+ break
+ fi
+ done
+
+ if [ -z "${PYTHON_CMD-}" ]; then
+ echo "Python executable not found; please set PYTHON_CMD" >&2
+ return 1
+ fi
+fi
Review Comment:
Thanks for the adjusted approach @fgerlits.
Reviewing the test itself, it seems like this is more suitable as an
integration test under the `nifi-system-test-suite` module. The `system-tests`
GitHub workflow already installs Python, and it is a better place to run longer
types of tests, such as this one that require installing dependency sets. What
do you think about refactoring this test into the system test module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
