szaszm commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1819016181
##########
CMakeLists.txt:
##########
@@ -670,6 +670,10 @@ include(CPack)
### include modules
if (NOT SKIP_TESTS)
+ enable_testing()
+ set(BUILD_TESTING ON)
+ set(CTEST_NEW_FORMAT true)
Review Comment:
what is CTEST_NEW_FORMAT?
##########
extensions/civetweb/tests/CMakeLists.txt:
##########
@@ -40,5 +40,6 @@ FOREACH(testfile ${CIVETWEB_INTEGRATION_TESTS})
"${CMAKE_SOURCE_DIR}/extensions/civetweb/tests/resources"
"$<TARGET_FILE_DIR:${testfilename}>/resources"
)
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "civetweb")
Review Comment:
why no memchecked here?
##########
extensions/aws/tests/CMakeLists.txt:
##########
@@ -35,5 +35,6 @@ FOREACH(testfile ${AWS_INTEGRATION_TESTS})
target_link_libraries(${testfilename}
minifi-expression-language-extensions)
MATH(EXPR AWS_TEST_COUNT "${AWS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}"
WORKING_DIRECTORY ${TEST_DIR})
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "aws")
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
